I think it's a matter of the final purpose for the map - if it's for your own personal use, no one else will ever see it (specially the players), and it contains the information you need to know in a format you can understand for your needs, then it's perfect

If you are planning on sending this out into the world as part of an adventure setting, I might suggest a more unified colour theme for the hills and such, maybe something not quite so dominating for the encounter areas, little things like that - but to me that's a personal preference thing. If it's for others, i would definitely add a scale marker, and perhaps a compass, and especially a legend to explain some of the symbols.